Skip to content

Merge push-kwkolvmuzkuu Into main#84

Merged
dclong merged 1 commit into
mainfrom
push-kwkolvmuzkuu
Jun 13, 2026
Merged

Merge push-kwkolvmuzkuu Into main#84
dclong merged 1 commit into
mainfrom
push-kwkolvmuzkuu

Conversation

@dclong

@dclong dclong commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new --ignore-patterns command-line argument to the create_pull_request.py script, allowing users to specify a list of regular expression patterns to ignore certain branches. The hardcoded check for branches starting with an underscore is replaced with a regex search over these patterns. The reviewer pointed out that invalid regular expressions can cause the script to crash with a re.error exception, and suggested validating and compiling the patterns beforehand to handle errors gracefully.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread github_rest_api/scripts/github/create_pull_request.py
@dclong dclong force-pushed the push-kwkolvmuzkuu branch from 2394fc4 to 1745685 Compare June 13, 2026 01:07
@dclong

dclong commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the create_pull_request.py script by adding support for regular expression-based branch ignore patterns (--ignore-patterns) and an option to update the head branch using the base branch before creating the pull request (--update). The reviewer suggested compiling all regular expression patterns prior to performing any branch matching to ensure that syntax errors in any of the patterns are caught immediately, rather than allowing the script to exit early on a match without validating subsequent patterns.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread github_rest_api/scripts/github/create_pull_request.py Outdated
@dclong dclong force-pushed the push-kwkolvmuzkuu branch from 1745685 to d9f2b16 Compare June 13, 2026 01:21
@dclong

dclong commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for ignoring branches based on regex patterns and updating the head branch before creating a pull request. It introduces a new compile_patterns utility function. The review feedback suggests improving this utility function by defensively handling None or empty inputs to prevent potential runtime errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread github_rest_api/utils.py Outdated
@dclong dclong force-pushed the push-kwkolvmuzkuu branch 2 times, most recently from bf7ee45 to 7743136 Compare June 13, 2026 01:40
@dclong

dclong commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to ignore branches matching specified regular expression patterns and optionally update the head branch before creating a pull request. It adds --ignore-patterns and --update CLI arguments to create_pull_request.py and implements a compile_patterns utility in utils.py. The review feedback suggests improving compile_patterns to handle cases where a single string is accidentally passed instead of a sequence, and adding a log message when a branch is skipped to improve observability in CI/CD workflows.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread github_rest_api/utils.py Outdated
Comment thread github_rest_api/scripts/github/create_pull_request.py
@dclong dclong force-pushed the push-kwkolvmuzkuu branch from 7743136 to 04ba89d Compare June 13, 2026 01:45
@dclong dclong force-pushed the push-kwkolvmuzkuu branch from 04ba89d to 833f3fa Compare June 13, 2026 02:17
@dclong

dclong commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to ignore specific branches when creating a pull request using regular expression patterns via the --ignore-patterns option, and adds an --update option to update the head branch with the base branch beforehand. It also adds a utility function compile_patterns to compile regex patterns. The feedback suggests improving the readability of a multi-line f-string expression in create_pull_request.py by splitting the f-string itself instead of placing a newline inside the curly braces.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread github_rest_api/scripts/github/create_pull_request.py
@dclong dclong merged commit ab64ffc into main Jun 13, 2026
8 checks passed
@dclong dclong deleted the push-kwkolvmuzkuu branch June 14, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant